Skip to content

chore(deps): Resolved CI test failures caused by unmocked universe_domain lookups#954

Merged
lahirumaramba merged 2 commits into
mainfrom
lm-fix-ci
Jun 29, 2026
Merged

chore(deps): Resolved CI test failures caused by unmocked universe_domain lookups#954
lahirumaramba merged 2 commits into
mainfrom
lm-fix-ci

Conversation

@lahirumaramba

Copy link
Copy Markdown
Member

Recent releases of google-auth introduced universe domain verification during before_request calls. For Compute Engine credentials, this verifies universe_domain, which attempts to query the Google Compute Engine metadata service at http://metadata.google.internal/computeMetadata/v1/universe/universe-domain.

Because MockGoogleComputeEngineCredential did not mock the universe_domain property, CI test runners failed to resolve metadata.google.internal, causing network timeout errors during test execution.

This change overrides the universe_domain property on MockGoogleComputeEngineCredential in tests/testutils.py to return 'googleapis.com', preventing external metadata server lookups during unit tests.

…redential

Added a universe_domain property override to MockGoogleComputeEngineCredential in tests/testutils.py to prevent unexpected network requests to the GCE metadata server during test runs with newer versions of google-auth.
@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a universe_domain property to a mock credentials class in tests/testutils.py that returns 'googleapis.com'. There are no review comments, and I have no feedback to provide.

@jonathanedey jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lahirumaramba lahirumaramba merged commit aa001ce into main Jun 29, 2026
24 checks passed
@lahirumaramba lahirumaramba deleted the lm-fix-ci branch June 29, 2026 15:46
morganchen12 pushed a commit that referenced this pull request Jun 29, 2026
…redential (#954)

Added a universe_domain property override to MockGoogleComputeEngineCredential in tests/testutils.py to prevent unexpected network requests to the GCE metadata server during test runs with newer versions of google-auth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants